Allow passing NTuple{N,T} as Ref{T}/Ptr{T} to ccall #34199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Dec 26, 2019
simonbyrne
force-pushed
the
sb/ntuple-ptr
branch
from
b1263e5
to
709169d
Compare
JeffBezanson
approved these changes
Dec 27, 2019
simonbyrne
force-pushed
the
sb/ntuple-ptr
branch
from
709169d
to
9556d49
Compare
|
NEWS item added (First Post!) |
| convert(Ptr{T}, unsafe_convert(Ptr{NTuple{N,T}}, r)) | ||
| unsafe_convert(::Type{Ptr{T}}, r::Ref{NTuple{N,T}}) where {N,T} = | ||
| convert(Ptr{T}, unsafe_convert(Ptr{NTuple{N,T}}, r)) | ||
| unsafe_convert(::Type{Ptr{T}}, r::Ptr{NTuple{N,T}}) where {N,T} = |
There was a problem hiding this comment.
I believe this method is redundant? (There is already an unsafe_convert method to go between pointer types.)
This makes it convenient when working with APIs that use small arrays. Based on discussion in https://discourse.julialang.org/t/ccall-with-pointer-argument-to-array-of-custom-type-via-an-ntuple-of-immutables/1048/2
simonbyrne
force-pushed
the
sb/ntuple-ptr
branch
from
385e710
to
4609ada
Compare
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
This makes it convenient when working with APIs that use small arrays. Based on discussion in https://discourse.julialang.org/t/ccall-with-pointer-argument-to-array-of-custom-type-via-an-ntuple-of-immutables/1048/2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it convenient when working with APIs that use small arrays.
Based on discussion on Slack with @vtjnash and Discourse comment by @yuyichao