Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Bump dependencies to fix ppc64le page size issues" #34108

Merged
merged 1 commit into from
Dec 15, 2019
Merged

Revert "Bump dependencies to fix ppc64le page size issues" #34108

merged 1 commit into from
Dec 15, 2019

Conversation

StefanKarpinski
Copy link
Sponsor Member

@StefanKarpinski StefanKarpinski commented Dec 15, 2019 •
edited
Loading

Reverts #34082. Since it seems to be causing download hash failures.

@giordano
Copy link
Contributor

giordano commented Dec 15, 2019 •
edited
Loading

I think reverting only the change to SUITESPARSE_BB_URL_BASE in deps/suitesparse.mk might be sufficient (or referencing the right tag). I was also almost about to delete the tag referenced by that change, as it's wrong. See message below

@giordano
Copy link
Contributor

giordano commented Dec 15, 2019 •
edited
Loading

Ok, I think something went very wrong with the registration of a new tag in SparseSuite_jll

@StefanKarpinski
Copy link
Sponsor Member Author

I'd rather revert this whole thing and get back to working CI; someone can unrevert it along with the rest of the fix once it's ready. In the meantime, this is causing all CI runs to fail.

@giordano
Copy link
Contributor

I'd rather revert this whole thing and get back to working CI

Yes, that's probably safer now.

@giordano giordano mentioned this pull request Dec 15, 2019
Merged
@vchuravy vchuravy merged commit 57cb6e0 into master Dec 15, 2019
@vchuravy vchuravy deleted the revert-34082-sf/fix_ppc64le_deps branch December 15, 2019 20:56
@vchuravy
Copy link
Sponsor Member

Reverted it for now, good way of finding a race condition in the system...

@maleadt maleadt mentioned this pull request Dec 16, 2019
Closed
@vchuravy vchuravy mentioned this pull request Dec 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy Awaiting requested review from vchuravy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StefanKarpinski @giordano @vchuravy