Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate (;) (#30115) #34039

Merged
merged 1 commit into from
Dec 12, 2019
Merged

deprecate (;) (#30115) #34039

merged 1 commit into from
Dec 12, 2019

Conversation

JeffBezanson
Copy link
Sponsor Member

No description provided.

@JeffBezanson JeffBezanson added parser Language parsing and surface syntax kind:minor change Marginal behavior change acceptable for a minor release labels Dec 6, 2019
ararslan
ararslan approved these changes Dec 7, 2019
View reviewed changes
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do you know whether any packages are still using this? I know a few were the last time this change was discussed but I don't know whether they were fixed.

StefanKarpinski
StefanKarpinski approved these changes Dec 9, 2019
View reviewed changes
Copy link
Sponsor Member

@StefanKarpinski StefanKarpinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@ararslan ararslan added the needs pkgeval Tests for all registered packages should be run with this change label Dec 9, 2019
@KristofferC
Copy link
Sponsor Member

KristofferC commented Dec 9, 2019 •
edited
Loading

@nanosoldier runtests(ALL, vs = ":master")

(this actually runs but benchmark nanosoldier overwrites the status message)

@maleadt
Copy link
Member

maleadt commented Dec 10, 2019 •
edited
Loading

This ran into some NewPkgEval/Nanosoldier bug (PkgEval stuff is still a WIP), so let's try again:
@nanosoldier runtests(ALL, vs = ":master")
EDIT: something went wrong, but I don't have time to debug today. I'll do so tomorrow.

@maleadt
Copy link
Member

maleadt commented Dec 11, 2019

Your test job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

PkgEval proving it's worth, of the new failures at least Dataflow.jl and Mocking.jl fail because of this PR.

@JeffBezanson
Copy link
Sponsor Member Author

Deprecation warning, then?

@JeffBezanson JeffBezanson added kind:deprecation This change introduces or involves a deprecation and removed needs pkgeval Tests for all registered packages should be run with this change labels Dec 11, 2019
@JeffBezanson JeffBezanson changed the title make (;) a parse error (#30115) deprecate (;) (#30115) Dec 11, 2019
@JeffBezanson JeffBezanson merged commit ce29ec5 into master Dec 12, 2019
@JeffBezanson JeffBezanson deleted the jb/emptynamedtuple branch December 12, 2019 03:34
aviatesk added a commit to aviatesk/IRTools.jl that referenced this pull request Dec 13, 2019
@aviatesk
update to JuliaLang/julia#34039
255893d
MikeInnes added a commit to FluxML/IRTools.jl that referenced this pull request Jan 10, 2020
@MikeInnes
Merge pull request #35 from aviatesk/deprecate;
0cfbb69 
update to JuliaLang/julia#34039
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
@JeffBezanson @KristofferC
deprecate (;) (#30115) (#34039)
c3e5357
@garrison garrison mentioned this pull request Feb 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
kind:deprecation This change introduces or involves a deprecation kind:minor change Marginal behavior change acceptable for a minor release parser Language parsing and surface syntax
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JeffBezanson @KristofferC @maleadt @StefanKarpinski @ararslan