[build] read uninstall from manifest #33906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps us uninstall the right content more generally. And this also lets us print a warning of the user's versions mismatch those in the repository (may be intentional, so we just print a warning so that the user is aware).
vtjnash
force-pushed
the
jn/manifest-uninst
branch
from
ac844cf
to
a24de21
Compare
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
This helps us uninstall the right content more generally. And this also lets us print a warning of the user's versions mismatch those in the repository (may be intentional, so we just print a warning so that the user is aware).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to be doing some testing and development work with switching LLVM versions. This helps us uninstall the right content more frequently, thus making the swap between versions cleaner and easier.
And this also lets us print a warning of the user's versions mismatch those in the repository (may be intentional, so we just print a warning so that the user is aware).
This is temporarily a bit noisy, but you can quickly silence it by doing a simplemake -C deps uninstallor a more aggressiverm -rf usr.