datatype: reorganize layout calculation code #33724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
force-pushed
the
jn/layout-reorg
branch
2 times, most recently
from
acda06b
to
85c5468
Compare
This lets us scan a datatype slightly easier, and opens up a future possibility where we don't have a one-to-one relationship between fields and contained pointers.
vtjnash
force-pushed
the
jn/layout-reorg
branch
from
85c5468
to
4e0d353
Compare
|
Seems unlikely to be noticeable, but just to check: @nanosoldier |
| @@ -296,165 +296,183 @@ static int references_name(jl_value_t *p, jl_typename_t *name) JL_NOTSAFEPOINT | |||
| return 0; | |||
| } | |||
|
|
|||
| static void throw_ovf(int should_malloc, void *desc, jl_datatype_t* st, int offset) | |||
| { | |||
| if (should_malloc) | |||
There was a problem hiding this comment.
I suppose it could. It's currently just carrying the same name along.
There was a problem hiding this comment.
Not so important I guess.
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code felt a bit disorganized to me, especially after #32448, and with the upcoming desire to eventually merge #18632. I think this will make it clearer when adopting further changes by changing where some of the early-return occurs and thus also removing some indentation (hence also, diff readability may be improved by ignoring whitespace).