simplify @allocated macro #33717
Merged
simplify @allocated macro #33717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| while false; end # compiler heuristic: compile this block (alter this if the heuristic changes) | ||
| local b0 = Ref{Int64}(0) | ||
| local b1 = Ref{Int64}(0) | ||
| gc_bytes(b0) |
There was a problem hiding this comment.
If this code is compiled, shouldn't it be ok for gc_bytes() to return a value?
There was a problem hiding this comment.
There's some code paths that'll compile but not infer this code. But anyways, it seemed nicer to be at least robust against ever including @allocated in the overhead.
Changes testset to avoid compiler heuristics (copyast) that disables inference. And changes the allocated macro to rely less on inference to elid allocations for the machinary itself.
|
Just to make sure this doesn't affect nanosoldier: @nanosoldier |
|
Your benchmark job has completed - no performance regressions were detected. A full report can be found here. cc @ararslan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a long list of gotchas in the
@allocatedmacro to deal with problems that it couldn't actually solve. The simplified macro doesn't have those issues—and even solves some of the issues it was trying to address. This needed an adjustment to@testsetto avoid it triggering the compiler heuristic that disables inference.