Clarified matrix column order example in performance-tips.md #33650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc/src/manual/performance-tips.md
Outdated
| @@ -778,6 +778,7 @@ adopted by C and Python (`numpy`) among other languages. Remembering the orderin | |||
| have significant performance effects when looping over arrays. A rule of thumb to keep in mind | |||
| is that with column-major arrays, the first index changes most rapidly. Essentially this means | |||
| that looping will be faster if the inner-most loop index is the first to appear in a slice expression. | |||
| Keep in mind that accessing an array with `:` is a loop. | |||
There was a problem hiding this comment.
Suggested change
| Keep in mind that accessing an array with `:` is a loop. | |
| Keep in mind that accessing an array with `:` is an implicit loop. |
mbauman
reviewed
Oct 28, 2019
Co-Authored-By: Matt Bauman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes clear to newcomers that accessing an array with
:is specifying a loop.(Nuked my old fork trying to fix an issue, so restoring PR #29894 based on my new fork, with changes.)