Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiplication of bidiagonal and triangular matrix (fixes #30094) #33584

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Fix multiplication of bidiagonal and triangular matrix (fixes #30094) #33584

merged 2 commits into from
Oct 17, 2019

Conversation

goggle
Copy link
Contributor

@goggle goggle commented Oct 16, 2019 •
edited
Loading

This PR intends to fix #30094.
Additionally, it also enables of multiplications Bidiagonal * adjoint(Triangular) and Bidiagonal * transpose(Triangular), where Triangular can be any triangular matrix type (LowerTriangular, UpperTriangular, UnitUpperTriangular, UnitLowerTriangular).

dkarrasch
dkarrasch requested changes Oct 17, 2019
View reviewed changes
Copy link
Member

@dkarrasch dkarrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

stdlib/LinearAlgebra/test/bidiag.jl Outdated Show resolved Hide resolved
@dkarrasch dkarrasch added the linear algebra Linear algebra label Oct 17, 2019
@StefanKarpinski StefanKarpinski merged commit 6a82665 into JuliaLang:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkarrasch dkarrasch dkarrasch approved these changes

Assignees
No one assigned
Labels
linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MethodError from *(::Bidiagonal, ::AbstractTriangular)
3 participants
@goggle @dkarrasch @StefanKarpinski