adding sort=true keyword to readdir() according to #24626 #33542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKarpinski
force-pushed
the
sk/sort_readdir
branch
from
ce5ec9e
to
1a19ca2
Compare
StefanKarpinski
force-pushed
the
sk/sort_readdir
branch
from
1a19ca2
to
77248d4
Compare
|
Are we expecting package_freebsd64 to fail these days? |
Keno
approved these changes
Oct 13, 2019
|
freebsd worked over on #32859, but I think it's generally been hit or miss. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurrection of #24675 in light of the recent massive scientific software failure due to different OSes sorting files in different orders in Python:
https://twitter.com/bmarwell/status/1181821143835201536
Let's do better.