Have copy(ci::CodeInfo) also copy ci.edges.
#33523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, it was a shallow-copy, so the array was shared between the orginal ci and the copy.
Keno
approved these changes
Oct 10, 2019
| cnew.ssaflags = copy(cnew.ssaflags) | ||
| ssavaluetypes = cnew.ssavaluetypes | ||
| cnew.ssaflags = copy(cnew.ssaflags) | ||
| cnew.edges = cnew.edges === nothing ? nothing : copy(cnew.edges) |
There was a problem hiding this comment.
@JeffBezanson: this is why it's sometimes handy to have copy methods for immutables—you want to copy something in case it's mutable, but maybe it isn't.
There was a problem hiding this comment.
In general you need x === nothing ? nothing : f(x); this is just a case of that. This argument clearly wouldn't apply to functions other than copy; I suspect copy just feels like a more reasonable function to implement since it's so close to the identity function.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, it was a shallow-copy, so the array was shared between the original ci and the copy.
CC: @vchuravy
Came up in JuliaLabs/Cassette.jl#148