Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove incorrect examples about thread-unsafe functions in docs #33419

Merged
merged 2 commits into from
Jan 8, 2020
Merged

remove incorrect examples about thread-unsafe functions in docs #33419

merged 2 commits into from
Jan 8, 2020

Conversation

KristofferC
Copy link
Sponsor Member

These two examples have been made thread-safe (regex and rand).

Now, it would be good to replace the examples with something else, illustrating the same point. Any ideas for a good example for that?

@KristofferC KristofferC added domain:docs This change adds or pertains to documentation domain:multithreading Base.Threads and related functionality labels Sep 30, 2019
@tkf
Copy link
Member

tkf commented Sep 30, 2019

rand(rng) seems to be a good example for mutation without !. There is also io = IOBuffer(); write(io, x).

For old rand()-like example, how about atexit? (Although I guess you can make it thread-safe quite easily)

@vtjnash
Copy link
Sponsor Member

vtjnash commented Dec 5, 2019

What is doc/my_file.txt? Seems like that wasn't supposed to be here?

@KristofferC
Copy link
Sponsor Member Author

No idea how that got there but it is gone now. Thanks

@KristofferC KristofferC closed this Jan 8, 2020
@KristofferC KristofferC reopened this Jan 8, 2020
@KristofferC KristofferC mentioned this pull request Jan 8, 2020
Closed
@KristofferC KristofferC merged commit 6088df6 into master Jan 8, 2020
@KristofferC KristofferC deleted the kc/thread_dos branch January 8, 2020 22:23
KristofferC added a commit that referenced this pull request Apr 11, 2020
@KristofferC
remove incorrect examples about thread-unsafe functions in docs (#33419)
50b82ce 
* remove incorrect examples about thread unsafe functions

* Delete my_file.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
domain:docs This change adds or pertains to documentation domain:multithreading Base.Threads and related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KristofferC @tkf @vtjnash