Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend against using the form rethrow(e) in docs #33296

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

c42f
Copy link
Member

@c42f c42f commented Sep 17, 2019

This form misrepresents what the program state was at the error site, and is largely obsoleted by the catch_stack functionality.

See also #29792

This misrepresents the program state and is largely obsoleted by the
catch_stack functionality.
@c42f c42f added domain:docs This change adds or pertains to documentation domain:error handling Handling of exceptions by Julia or the user labels Sep 17, 2019
@nickrobinson251
Copy link
Contributor

I wonder if this would be even better in a "Throwing Exceptions" Manual section, with code examples? (but fair enough if out of scope here)

Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good clarification to have!

@fredrikekre fredrikekre merged commit 7f2c436 into master Sep 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the cjf/rethrow-docs branch September 17, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:docs This change adds or pertains to documentation domain:error handling Handling of exceptions by Julia or the user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants