Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 5-arg mul! for tiled generic case #33218

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Fix 5-arg mul! for tiled generic case #33218

merged 1 commit into from
Sep 11, 2019

Conversation

tkf
Copy link
Member

@tkf tkf commented Sep 11, 2019

fix #33214

@tkf tkf mentioned this pull request Sep 11, 2019
Closed
tkf
tkf commented Sep 11, 2019
View reviewed changes
stdlib/LinearAlgebra/src/matmul.jl
@@ -762,7 +762,7 @@ function _generic_matmatmul!(C::AbstractVecOrMat{R}, tA, tB, A::AbstractVecOrMat
if isone(_add.alpha) && iszero(_add.beta)
copyto!(C, ib:ilim, jb:jlim, Ctile, 1:ilen, 1:jlen)
else
C[ib:ilim, jb:jlim] .= @views _add.(C[ib:ilim, jb:jlim], Ctile[1:ilen, 1:jlen])
C[ib:ilim, jb:jlim] .= @views _add.(Ctile[1:ilen, 1:jlen], C[ib:ilim, jb:jlim])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The arguments were swapped. It means that alpha and beta were swapped.

@KristofferC KristofferC added kind:bugfix This change fixes an existing bug backport 1.3 labels Sep 11, 2019
@KristofferC KristofferC added this to the 1.3 milestone Sep 11, 2019
@KristofferC KristofferC merged commit 09ff912 into JuliaLang:master Sep 11, 2019
KristofferC pushed a commit that referenced this pull request Sep 11, 2019
@tkf @KristofferC
Fix 5-arg mul! for tiled generic case (#33218)
b1eefc9 
(cherry picked from commit 09ff912)
@KristofferC KristofferC mentioned this pull request Sep 11, 2019
Merged
18 tasks
@andreasnoack andreasnoack added the domain:linear algebra Linear algebra label Sep 11, 2019
KristofferC pushed a commit that referenced this pull request Sep 19, 2019
@tkf @KristofferC
Fix 5-arg mul! for tiled generic case (#33218)
dc642ad 
(cherry picked from commit 09ff912)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
domain:linear algebra Linear algebra kind:bugfix This change fixes an existing bug
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

5-arg mul gives wrong result
3 participants
@tkf @andreasnoack @KristofferC