remove trim option to fkeep! and related functions #32972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Triage because it is a bit unclear what to do here. This is clearly breaking but the pr #31724 documents that the matrices generated by |
|
Triage: Check how much this is used in practice, and decide something based on that. |
74d2e07
to
fac0eb6
Compare
|
@nanosoldier |
fac0eb6
to
f99219c
Compare
|
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt |
|
PkgEval looks clean, added a NEWS entry, will merge in a while unless I hear something. |
birm
pushed a commit
to birm/julia
that referenced
this pull request
Feb 22, 2020
* remove trim option to fkeep! and related functions * add NEWS entry
KristofferC
added a commit
that referenced
this pull request
Apr 11, 2020
* remove trim option to fkeep! and related functions * add NEWS entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #31724, the whole
trimthing doesn't make sense since it is producing SparseArrays that are invalid according to our consistency checks.Therefore, just remove the
trimoption.AFAIU, we are also trying to move away from having an uninitialized "tail" in the different internal vectors as well.
Fixes #32967