Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix overwritten unescape_string #32925

Merged
merged 1 commit into from
Aug 16, 2019
Merged

fix overwritten unescape_string #32925

merged 1 commit into from
Aug 16, 2019

Conversation

rfourquet
Copy link
Member

Introduced in #30513.
Also updates the docstring.

@rfourquet rfourquet added the domain:strings "Strings!" label Aug 16, 2019
@rfourquet
Copy link
Member Author

rfourquet commented Aug 16, 2019 •
edited
Loading

Applying label forgemenot, ([edit] by transitivity for fun), as it was on the PR mentioned in the OP :)

@rfourquet rfourquet added the status:forget me not PRs that one wants to make sure aren't forgotten label Aug 16, 2019
@JeffBezanson JeffBezanson merged commit 387eb80 into master Aug 16, 2019
@JeffBezanson JeffBezanson deleted the rf/fix-unescape_string branch August 16, 2019 17:43
@simeonschaub simeonschaub removed the status:forget me not PRs that one wants to make sure aren't forgotten label May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
domain:strings "Strings!"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rfourquet @JeffBezanson @simeonschaub