Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement isdiag(::Bidiagonal), add tests #32694

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Implement isdiag(::Bidiagonal), add tests #32694

merged 1 commit into from
Jul 30, 2019

Conversation

garrison
Copy link
Sponsor Member

No description provided.

@mcognetta
Copy link
Contributor

mcognetta commented Jul 26, 2019 •
edited
Loading

This one doesn't help it seems. isdiag falls back to isbanded which falls back to istril and istriu so having efficient implementations of those two (which we do) is sufficient.

EDIT:
Actually, I just timed this and I was wrong. It seems we need efficient implementations of istril(B, k) and istriu(B, k) for Bidiagonal matrices and then its ok.

@andreasnoack andreasnoack added the domain:linear algebra Linear algebra label Jul 27, 2019
@garrison
Copy link
Sponsor Member Author

@mcognetta if you feel that this can be done better, feel free to make a PR that supersedes this one :)

@andreasnoack
Copy link
Member

The current version is very simple so let's just have it.

@andreasnoack andreasnoack merged commit 25eb8c6 into JuliaLang:master Jul 30, 2019
@garrison garrison deleted the jrg/bidiag branch July 30, 2019 15:03
JeffBezanson pushed a commit that referenced this pull request Aug 5, 2019
@garrison @JeffBezanson
Implement isdiag(::Bidiagonal), add tests (#32694)
5f4a567 
(cherry picked from commit 25eb8c6)
KristofferC pushed a commit that referenced this pull request Aug 26, 2019
@garrison @KristofferC
Implement isdiag(::Bidiagonal), add tests (#32694)
c1dfab4 
(cherry picked from commit 25eb8c6)
@KristofferC KristofferC mentioned this pull request Aug 26, 2019
Merged
55 tasks
KristofferC pushed a commit that referenced this pull request Aug 26, 2019
@garrison @KristofferC
Implement isdiag(::Bidiagonal), add tests (#32694)
1005051 
(cherry picked from commit 25eb8c6)
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
@garrison @KristofferC
Implement isdiag(::Bidiagonal), add tests (#32694)
a05a37c 
(cherry picked from commit 25eb8c6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
domain:linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@garrison @mcognetta @andreasnoack @JeffBezanson @KristofferC