WIP: Add Vagrant configuration #3266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the limitations of VirtualBox shared folders, symlinks need to be replaced with either file copies or elided entirely.
| @@ -30,3 +30,4 @@ | |||
|
|
|||
| /usr | |||
| /COMMIT | |||
| /contrib/vagrant/.vagrant | |||
There was a problem hiding this comment.
I would prefer this to be ignored via a /.vagrant entry in contrib/vagrant/.gitignore. That was the directory is relocatable.
|
I don't know anything about Vagrant, but this sounds cool and useful and the patch looks safe to me. |
|
I have done a bunch of work with/on Vagrant and this is an excellent idea. LGTM (though I haven't actually tested it). |
|
I still need to test this on my regular VM to make sure my Makefile changes are right and Linux still builds. I also need to add a blurb to README.md. Will merge after. |
|
Actually, obviously the Travis build worked, so I guess we're good here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a ready-to-go environment for working on Julia, with an eye towards Windows developers who would like to contribute to core, or to test on Linux. The Julia repository is shared between the host and guest, so editing files can be done in the host environment in your editor of choice.
It's a bit clunky--you have to run
git submodule initandgit submodule updatefrom the host before our Make process gets to it or it messes up the submodule references; you also need to use themake $BUILDOPTS(aliased tojlmake) to ensure you get a fully USE_SYSTEM_* build. At the very least, a full build in VirtualBox on Windows is impossible due to theaux/directory in the libunwind tarball.Due to the limitations of VirtualBox shared folders, symlinks need to be replaced with either file copies or elided entirely.