Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #21360, make global bindings thread safe #32370

Merged
merged 1 commit into from
Jul 12, 2019
Merged

fix #21360, make global bindings thread safe #32370

merged 1 commit into from
Jul 12, 2019

Conversation

JeffBezanson
Copy link
Sponsor Member

fixes #21360

@JeffBezanson JeffBezanson added the domain:multithreading Base.Threads and related functionality label Jun 19, 2019
@vtjnash
Copy link
Sponsor Member

vtjnash commented Jun 26, 2019

@nanosoldier runbenchmarks(ALL, vs=":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jun 28, 2019

Should this use lock_nogc? It's failing the gc-checker, so it seems it either needs fixing or narrowing of the lock scope.

Also needs adding to the devdocs

@JeffBezanson JeffBezanson merged commit 2964312 into master Jul 12, 2019
@JeffBezanson JeffBezanson deleted the jb/modulelock branch July 12, 2019 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
domain:multithreading Base.Threads and related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

module.c code is not threadsafe
3 participants
@JeffBezanson @vtjnash @nanosoldier