Update Windows icon and NSIS banner

[musm]

part of #32038

It looks like the old icon had a smaller size, updating it now looks much better.

[musm]

I'm not sure why but the julia exe files are still using the old icons even after updating them. It might have something to do with the 7zS.sfx ? the julia.rc file specifies the icon as julia.ico which is the same folder as the julia.rc file so I don't know why it is not picking up the refreshed icons.

[StefanKarpinski]

Thanks for polishing this!

[musm]

Fixed up the actual 7z stage of the installer icon, it needed manual modification using resource hacker.

@vtjnash do you by any chance know why the actual julia.exe is not picking up the julia.ico changes? My understanding was that julia.rc is involved. https://github.com/JuliaLang/julia/blob/master/contrib/windows/julia.rc#L34

[musm]

So what I think was happening was that the resource file defined the same number for VERSIONINFO and ICON

julia/contrib/windows/julia.rc

Line 3 in 1d4b25e

1 VERSIONINFO

julia/contrib/windows/julia.rc

Line 34 in 1d4b25e

101 ICON "julia.ico"

changing the resource number for ICON to 101 (the number is arbitrary and doesn't matter unless it is referenced), seems to fix the clash and now builds properly update the icons to the new ones.

I'm not sure if it was some strange luck that the current version works. It could be related to the sizes embedded in the ico file on master are smaller than the updated ico file in this PR (which have embedded more icon sizes)

Compare the new icon (red arrow) to the old icon on the right in the figure below

[vtjnash]

I assume it's just because you modified the file so it rebuilt. There's no conflict, so it'll just pick up the lowest number in each group (1, 24, and 101; or it could have been 1, 1, and 1)

[musm]

I don't think so? I deleted my icon cache and I made sure to distclean and built from scratch, but it still persisted, before renumbering.

[musm]

Seems like you were right.... It's pretty annoying to mess around with icons since things don't always refresh properly...

[musm]

I fixed up a very subtle scaling issue (@cormullion the julia-dots.svg isn't perfectly square and there is some space even around the widest dots, I trimmed that space and made it a perfect square, which fixed the scaling in the creation of the ico files)

[musm]

FYI this is good to go on my end

[musm]

merge?

[KristofferC]

Is the Title change and the ShowUninstDetails change part of the icon change?

[ViralBShah]

I believe they are part of the NSIS banner change which we discussed elsewhere. Let's go ahead with this.

[musm]

Yeah it's not entirely related to the branding update. The showuninst improves consistency with the installer and the name change actually has no impact due to the 7zSFX module used is outdated, but I changed it anyways if it gets updated.