Ensure syntax error locations appear in backtraces #31881
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors which are thrown directly inside
jl_toplevel_eval_flex
do not get an entry in the backtrace. The most prominent of these are syntax errors, but there's other cases too.Fix this by constructing a julia expression throwing the appropriate error, and
eval
ing it to generate a julia-level frame.This is one step toward removing
LoadError
as part of addressing #31830 but seems useful on its own.I feel like there should be a better way to get an appropriate julia frame into the backtrace but this is relatively simple and expedient.