Fix edit when command is set to Visual Studio code

[musm]

By default VS Code adds code.cmd to path. Thus simply setting the JULIA_EDITOR=code (the obvious thing) will fail since julia, without knowing it is a cmd, assumes it is an exe. The logic here is thus special cased.

I decided to refrain from making this change in this PR (see the last comment)

This fixes the incorrect fall through in the scenario where the user sets JULIA_EDITOR=code.cmd, since name == "code" || (Sys.iswindows() && uppercase(name) == "CODE.EXE") does not capture this case, which prevents line information passing through.

JULIA_EDITOR=code.cmd, should work since code.cmd is added to path by VS Code.

[musm]

cc @davidanthoff

[davidanthoff]

I assume this is in relation to this line, correct?

[musm]

This change was actually independent of the vs-code plugin and discovered from trying to set vscode as the REPL editor. I pinged you since you are familiar with vscode and thus would be an appropriate reviewer.

For the change you linked to, what does process.execPath point to? If it points to the exe then it will work and this PR does not touch that.

This PR fixes the case when you set JULIA_EDITOR=code (MSFT automatically adds code.cmd) to path, which right now does not work. It also fixes the case when you link to C:\Program Files\Microsoft VS Code\bin\code.cmd. If you set it to C:\Program Files\Microsoft VS Code\Code.exe it will work and this PR does not affect this scenario.

[davidanthoff]

process.execPath points to the exe, so that should be all good pre and post this PR, right?

So yes, then this PR looks good to me :)

[musm]

process.execPath points to the exe, so that should be all good pre and post this PR, right?

Yes, that case is unaffected. This PR expands the scope to be more lenient.

[musm]

squashed and good to go on my end

[musm]

I should clarify that I decided to make this the most minimal change after thinking about various cases more carefully.

The behavior before the squash was more permissive, but I think the minimal change just pushed is OK overall and improves the situation.

[musm]

this is good to merge

[StefanKarpinski]

Anyone use VS Code and want to try this and then merge it, assuming it works?

[musm]

Could we add this to backport?

[KristofferC]

Feature freeze was long ago so not really.

[musm]

Makes sense. I'm not sure the procedure for backporting PRs, but for the next release including this PR would be appreciated.