fix #31803, covariance handling in fieldtype_tfunc
#31848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
reviewed
Apr 26, 2019
| @@ -939,7 +939,7 @@ function _fieldtype_tfunc(@nospecialize(s), exact::Bool, @nospecialize(name)) | |||
| ft = ftypes[fld] | |||
| end | |||
|
|
|||
| exactft = exact || !has_free_typevars(ft) | |||
| exactft = exact || (!has_free_typevars(ft) && u.name !== Tuple.name) | |||
There was a problem hiding this comment.
Doesn't seem specific to the typevar case?
julia> Core.Compiler.fieldtype_tfunc(Type{Tuple{Any}}, Const(1))
Const(Any, false)
There was a problem hiding this comment.
fieldtype(Tuple{Any}, 1) does return Any, so I think that result is ok.
|
I suggest also applying the same fix on line 909: |
vtjnash
approved these changes
Apr 27, 2019
6e9faab
to
13a3a15
Compare
KristofferC
pushed a commit
that referenced
this pull request
May 9, 2019
(cherry picked from commit a78f895)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #31803