fix potential stack overflow in Profile.jl #31693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Apr 11, 2019
|
Here's where we'll fail now: https://build.julialang.org/#/builders/13/builds/1692/steps/2/logs/stdio (fwiw, I think this is the only other place that needs the same change) |
Keno
added a commit
that referenced
this pull request
May 1, 2019
As a follow up to #31693, this fixes the other place in Profile that recurses over Profile data, causing stack overflows. This should fix a bunch of the recent intermittent CI faults on linux32.
Keno
added a commit
that referenced
this pull request
May 1, 2019
As a follow up to #31693, this fixes the other place in Profile that recurses over Profile data, causing stack overflows. This should fix a bunch of the recent intermittent CI faults on linux32.
Keno
added a commit
that referenced
this pull request
May 2, 2019
As a follow up to #31693, this fixes the other place in Profile that recurses over Profile data, causing stack overflows. This should fix a bunch of the recent intermittent CI faults on linux32.
KristofferC
pushed a commit
that referenced
this pull request
May 15, 2019
(cherry picked from commit 6308ebd)
KristofferC
pushed a commit
that referenced
this pull request
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will hopefully fix the stack overflow we've seen many times in CI (e.g. https://build.julialang.org/#/builders/13/builds/1552/steps/2/logs/stdio).