Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doctest from utf8proc update. #31688

Merged
merged 1 commit into from
Apr 12, 2019

Conversation

fredrikekre
Copy link
Member

Hearts are now smaller.

@fredrikekre fredrikekre added backport 1.2 domain:docs This change adds or pertains to documentation labels Apr 11, 2019
@JeffBezanson
Copy link
Sponsor Member

JeffBezanson commented Apr 11, 2019

This character is still full-width for me ¯\_(ツ)_/¯

@JeffBezanson JeffBezanson added the domain:unicode Related to unicode characters and encodings label Apr 11, 2019
@KristofferC
Copy link
Sponsor Member

Tangentially, does failing doctests not fail the build anymore?

@StefanKarpinski
Copy link
Sponsor Member

does failing doctests not fail the build anymore?

@staticfloat ^

@fredrikekre
Copy link
Member Author

They are only running on Travis Linux 64-bit. I'm guessing this failure got through while Travis was a bit wonky for some days.

@fredrikekre fredrikekre merged commit bbb8eae into JuliaLang:master Apr 12, 2019
@fredrikekre fredrikekre deleted the fe/width-of-the-heart branch April 12, 2019 05:22
KristofferC pushed a commit that referenced this pull request Apr 15, 2019
@KristofferC KristofferC mentioned this pull request Apr 15, 2019
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:docs This change adds or pertains to documentation domain:unicode Related to unicode characters and encodings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants