Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regressed compilation of uncached code. #31687

Merged
merged 2 commits into from
Apr 12, 2019
Merged

Fix regressed compilation of uncached code. #31687

merged 2 commits into from
Apr 12, 2019

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Apr 11, 2019

Had been broken for a while, probably after #31191. Fix by @vtjnash.

@maleadt maleadt added the compiler:codegen Generation of LLVM IR and native code label Apr 11, 2019
@vchuravy
Copy link
Member

Is it feasible to test this?

@vchuravy vchuravy added this to the 1.2 milestone Apr 11, 2019
@maleadt
Copy link
Member Author

maleadt commented Apr 11, 2019 •
edited
Loading

I guess, but cached=false should disappear soon anyway so probably not worth it (#25984).
Gets triggered by CUDAnative.jl's test suite.

@maleadt maleadt merged commit 1aa8c68 into master Apr 12, 2019
@maleadt maleadt deleted the tb/uncached_codeinst branch April 12, 2019 14:08
@vchuravy vchuravy mentioned this pull request Apr 12, 2019
Closed
@KristofferC KristofferC mentioned this pull request Apr 15, 2019
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
compiler:codegen Generation of LLVM IR and native code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maleadt @vchuravy @KristofferC