Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix undefined variable error in uncompress_ast #31613

Merged
merged 2 commits into from
Apr 4, 2019
Merged

fix undefined variable error in uncompress_ast #31613

merged 2 commits into from
Apr 4, 2019

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Apr 4, 2019

Introduced by #31191

I managed to trigger this by executing:

Base.Threads.@threads for i in 1:Base.Threads.nthreads()
           if Base.Threads.threadid() == 1
             tasks = Task[]
             for i in 1:10
               t = Task(()->println("tid: ", Base.Threads.threadid()))
               t.sticky = false
               push!(tasks, t)
               schedule(t)
             end
             Base.sync_end(tasks)
           end
        end

Or by compiling the sysimage with JULIA_NUM_THREADS=4 set.

@vtjnash what would be the expected codepath to trigger this method?

@vchuravy vchuravy added needs tests Unit tests are required for this change bugfix This change fixes an existing bug labels Apr 4, 2019
@vchuravy vchuravy requested a review from vtjnash April 4, 2019 14:17
@vchuravy vchuravy changed the title fix undefined variable error fix undefined variable error in uncompress_ast Apr 4, 2019
@JeffBezanson JeffBezanson merged commit e449cd4 into master Apr 4, 2019
@JeffBezanson JeffBezanson deleted the vc/li branch April 4, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug needs tests Unit tests are required for this change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants