getipaddrs: make loopback (Bool) a keyword argument #31594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpsamaroo
reviewed
Apr 3, 2019
| @@ -267,7 +269,7 @@ julia> getipaddrs(IPv6) | |||
| ip"fe80::445e:5fff:fe5d:5500" | |||
| ``` | |||
| """ | |||
| function getipaddrs(addr_type::Type{T}, include_lo::Bool=false) where T<:IPAddr | |||
| function getipaddrs(addr_type::Type{T}=IPAddr; loopback::Bool=false) where T<:IPAddr | |||
There was a problem hiding this comment.
Thanks for adding in the 0-argument method, seems like I forgot that in my PR. ❤️
There was a problem hiding this comment.
You had it, it just couldn’t be specified like this because of the interaction with non-keyword loopback argument. See the method I deleted right below this one.
|
AppVeyor and Travis failures don't seem related but man does the CI situation not make me super comfortable to merge anything. |
|
I want to make sure this gets into the 1.2 release since this is a change to a new API and if it doesn't make it into 1.2 we can't change this in 1.3. |
|
Unrelated, but |
|
Reminder to self: squash this when you merge it and fix the commit message. |
StefanKarpinski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a somewhat better API. Boolean arguments are often better as keywords since the value itself conveys so little contextual information. The loopback argument and the type argument are also orthogonal which this allows us to express slightly more easily (i.e. with a single method definition).