Specify type on CodeInfo.slotnames #31541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see any reason not to just make it |
timholy
force-pushed
the
teh/codeinfo_types
branch
from
e0f9692
to
44cada7
Compare
JeffBezanson
approved these changes
Mar 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
julia.h is more specific on this point than the type declaration. Is there any reason not to make it a
Vector{Symbol}?This is a surprisingly hot spot for JuliaInterpreter, e.g., https://github.com/JuliaDebug/JuliaInterpreter.jl/blob/ceee9c06dae85c79d5e7e918e4ed8c68ef5b180f/src/construct.jl#L264 (frame data preparation is our biggest cost for many workloads).