Add inv(::Missing) #31451
Add inv(::Missing) #31451
Conversation
ararslan
added
needs news
test/missing.jl
Outdated
| @@ -81,7 +81,7 @@ end | |||
| arithmetic_operators = [+, -, *, /, ^, Base.div, Base.mod, Base.fld, Base.rem] | |||
|
|
|||
| # All unary operators return missing when evaluating missing | |||
| for f in [!, ~, +, -] | |||
| for f in [!, ~, +, -, inv] | |||
There was a problem hiding this comment.
Can you put with with elementary functions instead?
Also, please add an entry in NEWS.md.
There was a problem hiding this comment.
About the compat annotation, Should I just add inv under unary operators in missing.md?
There was a problem hiding this comment.
Sorry, I'm not sure what you mean. In NEWS.md, please add an entry under "New language features".
There was a problem hiding this comment.
Please check the most recent commit. My query was regarding needs compat annotation label.
There was a problem hiding this comment.
My query was regarding
needs compat annotationlabel.
Ah, OK. I don't think it's appropriate since there's no docstring. @ararslan?
EDIT: I guess we could add a !!! compat "Julia 1.2" block to the inv docstring mentioning missing values.
There was a problem hiding this comment.
Yes, it should be in the existing docstring for inv
narendrakpatel
force-pushed
the
np/inv-missing
branch
from
eba30f0
to
a7a27d2
Compare
narendrakpatel
force-pushed
the
np/inv-missing
branch
from
a7a27d2
to
8285d78
Compare
ararslan
removed
needs compat annotation
|
If this is okay, can this be merged? @ararslan |
Closes #31408
Adds
inv(::Missing)Adds test for
inv(::Missing)