small changes 2 #31440
Merged
small changes 2 #31440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we cannot have real symlinks, we can perhaps fake it enough for convenience purposes.
This output is known to contain latin-1 characters, (from our using of NSIS Modern User Interface 2.0), but the terminal is probably in utf-8 mode, so this this is known to make some bad terminal emulators (*cough*python*cough*) sad.
We previously claimed that: "Skip over objects without a path (as they represent this own object)" This was false on two levels: - On everything non-glibc the binary does have a path - On linux, there is also usually also at least one shim object that does not have a path So instead, we filter these out explicitly at the end (and remove some duplicate code paths).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently I had even more assorted small change lying around that I think might be improvements.