Explicitly ask for HFS+ filesystems when creating .dmg files on MacOS
#31385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViralBShah
added
system:mac
staticfloat
force-pushed
the
sf/exfat_dmg
branch
from
9fbf4b2
to
21437be
Compare
staticfloat
changed the title
ExFAT filesystems when creating .dmg files on MacOSHFS+ filesystems when creating .dmg files on MacOS
…acOS This is necessary for cross-compatibility, as if a user creates a `.dmg` file on a newer version of MacOS, it may default to `APFS` which is unreadable on MacOS 10.11 and lower.
staticfloat
force-pushed
the
sf/exfat_dmg
branch
from
21437be
to
5eb1f6e
Compare
|
Turns out you can't always use |
|
This now works on the macOS buildbot, so I'm going to go ahead and merge it. |
raphbacher
pushed a commit
to raphbacher/julia
that referenced
this pull request
Mar 19, 2019
…acOS (JuliaLang#31385) This is necessary for cross-compatibility, as if a user creates a `.dmg` file on a newer version of MacOS, it may default to `APFS` which is unreadable on MacOS 10.11 and lower.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for cross-compatibility, as if a user creates a
.dmgfile on a newer version of MacOS, it may default to
APFSwhich isunreadable on MacOS 10.11 and lower.