Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed function 'warn' to macro '@warn' in runtests.jl #31262

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Changed function 'warn' to macro '@warn' in runtests.jl #31262

merged 1 commit into from
Mar 7, 2019

Conversation

macd
Copy link
Contributor

@macd macd commented Mar 5, 2019

runtests.jl for the SHA module uses the nonexistant warn function. Changed that to the @warn macro call.

@StefanKarpinski
Copy link
Sponsor Member

@c42f: would you mind reviewing this?

@fredrikekre fredrikekre merged commit 73e9535 into JuliaLang:master Mar 7, 2019
@c42f
Copy link
Member

c42f commented Mar 8, 2019

Well I'm a bit late to the party but FWIW it looks fine to me. Straightforward translation like this should always be possible for warn->@warn with a string argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants