SuiteSparse: fix shlib build #31196
Merged
SuiteSparse: fix shlib build #31196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related #31102 |
Lots changed about the build in v5, with some of our old workarounds getting in the way of changes to the SuiteSparse build system, and some upstream "(untested)" code that was, of course therefore, wrong.
vtjnash
force-pushed
the
jn/suitesparse5
branch
from
953cbe5
to
34598a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we switched to Suitesparse v5, we simultaneously turned on binary builder too, so we didn't notice that upstream and this build script were now broken. Lots changed about the build in version 5,
with some of our old workarounds getting in the way of changes to the SuiteSparse build system, and some upstream "(untested)" code that was, of course therefore, wrong.
fixes #31070