don't default to compact output in 2-argument show methods
#31087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
the
domain:display and printing
vtjnash
approved these changes
Feb 16, 2019
JeffBezanson
force-pushed
the
jb/nocompact
branch
from
7c3af97
to
2076c52
Compare
rfourquet
added a commit
that referenced
this pull request
May 10, 2019
JeffBezanson
pushed a commit
that referenced
this pull request
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's better to consistently avoid setting
:compactin 2-argumentshowmethods --- otherwise you sometimes need to pass:compact => falseto get full output. Having a couple extra spaces around=>is perfectly readable and more consistent.UniformScalingandLQshow methods needed to be for text/plain since they use pretty multi-line formats.