Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an isless method for Base.UUID #30947

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Add an isless method for Base.UUID #30947

merged 1 commit into from
Feb 4, 2019

Conversation

ararslan
Copy link
Member

@ararslan ararslan commented Feb 3, 2019

This permits the removal of a pirated method in Pkg.

This permits the removal of a pirated method in Pkg.
@ararslan ararslan mentioned this pull request Feb 3, 2019
27 tasks
@ararslan
Copy link
Member Author

ararslan commented Feb 4, 2019

The macOS failure is unrelated, but concerning:

ccache: error: Could not find compiler "gfortran" in PATH
Traceback (most recent call last):
  File "/Users/travis/build/JuliaLang/julia/contrib/normalize_triplet.py", line 118, in <module>
    }[sys.argv[2][0]]

I haven't seen that before.

Also it looks like FreeBSD isn't being triggered?

@KristofferC
Copy link
Sponsor Member

Pkg could just implement the sorting using a by argument if it wants to sort by UUID?

@StefanKarpinski
Copy link
Sponsor Member

I do get that the sort order for UUIDs is kind of arbitrary since the values don't mean anything but how else would you sort them? Sometimes you just want to sort some UUIDs in a predictable order and this is pretty much the only reasonable choice.

@StefanKarpinski StefanKarpinski merged commit 5695f83 into master Feb 4, 2019
@StefanKarpinski StefanKarpinski deleted the aa/uuid-isless branch February 4, 2019 13:19
@StefanKarpinski
Copy link
Sponsor Member

macOS failure was #30949 (unrelated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants