Tests for bad arguments to at-threads #30937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My tests passed on OSX, the failure is in |
fredrikekre
reviewed
Feb 5, 2019
|
Failure seems due to a failed internet connection. Maybe kick the robot and merge @kshyatt ? |
vtjnash
reviewed
Mar 11, 2022
|
Done |
|
@vtjnash good to go? |
|
ah, sorry, I forgot, and looks like CI was in a bad state. Let's see if we can get a good run and merge |
ccaa1a5
to
3109d20
Compare
3109d20
to
cbc8923
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully I did the right thing with
macroexpand! These guys are untested according to coverage.