Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix overflow message (var y should not be in quotes) #30905

Merged
merged 2 commits into from
Jan 31, 2019
Merged

fix overflow message (var y should not be in quotes) #30905

merged 2 commits into from
Jan 31, 2019

Conversation

JeffreySarnoff
Copy link
Contributor

In the OverflowError message, the y argument is in quotes, so the error message is similar to:
ERROR: OverflowError: 1 +y overflowed for type Int64

rather than

ERROR: OverflowError: 1 + 9223372036854775807 overflowed for type Int64

old:

throw_overflowerr_binaryop(op, x, y) = (@_noinline_meta;
    throw(OverflowError(Base.invokelatest(string, x, " ", op, "y", " overflowed for type ", typeof(x)))))

new:

throw_overflowerr_binaryop(op, x, y) = (@_noinline_meta;
    throw(OverflowError(Base.invokelatest(string, x, " ", op, y, " overflowed for type ", typeof(x)))))

base/checked.jl Outdated
@@ -151,7 +151,7 @@ end


throw_overflowerr_binaryop(op, x, y) = (@_noinline_meta;
throw(OverflowError(Base.invokelatest(string, x, " ", op, "y", " overflowed for type ", typeof(x)))))
throw(OverflowError(Base.invokelatest(string, x, " ", op, y, " overflowed for type ", typeof(x)))))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a " " before the y to avoid squishing the text?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is a good move -- changed below

@KristofferC
Copy link
Sponsor Member

What was wrong with #30898?

@JeffreySarnoff
Copy link
Contributor Author

What was wrong with #30898?

The bsd ci build failed for a reason unrelated to this PR, and this is the only way I knew to rebuild it.

@KristofferC
Copy link
Sponsor Member

Close and reopen should do it.

@JeffreySarnoff
Copy link
Contributor Author

JeffreySarnoff commented Jan 31, 2019

last build, travis failed with this

Installing APT Packages
13.18s$ travis_apt_get_update
0.44s$ sudo -E apt-get -yq --no-install-suggests --no-install-recommends $(travis_apt_get_options) install ccache libssl1.0.0 bar time g++-5 gfortran-5
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package g++-5
E: Couldn't find any package by regex 'g++-5'
E: Unable to locate package gfortran-5
apt-get.diagnostics
apt-get install failed
...
W: Failed to fetch http:https://ppa.launchpad.net/couchdb/stable/ubuntu/dists/trusty/main/binary-i386/Packages  Unable to connect to ppa.launchpad.net:http:
W: Some index files failed to download. They have been ignored, or old ones used instead.
The command "sudo -E apt-get -yq --no-install-suggests --no-install-recommends $(travis_apt_get_options) install ccache libssl1.0.0 bar time g++-5 gfortran-5" failed and exited with 100 during .
Your build has been stopped.

I have restarted it all .. if there is something else to be done, let me know.

@JeffreySarnoff
Copy link
Contributor Author

attempt 3 close+reopen

@KristofferC KristofferC merged commit 566059b into JuliaLang:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants