Don't use recursion in IncrementalCompact #30885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct, ...)` This dodges a stack overflow seen with extremely large blocks of code
ararslan
reviewed
Jan 29, 2019
ararslan
reviewed
Jan 29, 2019
Co-Authored-By: Keno <[email protected]>
|
If only we had TCO |
|
Can this be backported? It fixes #31244. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dodges a stack overflow seen with extremely large blocks of code.
This commit was lying around on kf/tpu3, but it's generally applicable to avoid stack overflows when simplifying large bits of code. That doesn't tend to happen as often on master (because the ir tends to be smaller, because master does less inlining), but it is a possibility, so we might as well take the fix.