Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix julia installer permission on windows #30841

Merged
merged 2 commits into from
Jan 28, 2019
Merged

Fix julia installer permission on windows #30841

merged 2 commits into from
Jan 28, 2019

Conversation

musm
Copy link
Contributor

@musm musm commented Jan 25, 2019 •
edited
Loading

Fix #29719 , by correctly setting executable permissions so the installer is able to run from Windows.

@musm
Copy link
Contributor Author

musm commented Jan 28, 2019

cc @vtjnash (your recommendation)

@ViralBShah
Copy link
Member

This was what @vtjnash suggested in the linked issue. So looks good.

@ViralBShah ViralBShah added system:windows Affects only Windows domain:building Build system, or building Julia or its dependencies labels Jan 28, 2019
@ViralBShah ViralBShah merged commit 8b7c88c into JuliaLang:master Jan 28, 2019
@musm musm deleted the patch-4 branch January 28, 2019 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticfloat staticfloat Awaiting requested review from staticfloat

Assignees
No one assigned
Labels
domain:building Build system, or building Julia or its dependencies system:windows Affects only Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@musm @ViralBShah