Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify setproperty! lowering #30818

Merged
merged 1 commit into from
Jan 31, 2019
Merged

simplify setproperty! lowering #30818

merged 1 commit into from
Jan 31, 2019

Conversation

JeffBezanson
Copy link
Sponsor Member

AFAICT this is unnecessary, since in Core where setproperty! === setfield! the convert function is only identity.

@JeffBezanson JeffBezanson added the compiler:lowering Syntax lowering (compiler front end, 2nd stage) label Jan 23, 2019
@stevengj
Copy link
Member

stevengj commented Jan 30, 2019 •
edited
Loading

Did this somehow relate to #16195? Probably not...

@JeffBezanson JeffBezanson merged commit 82d7bd3 into master Jan 31, 2019
@JeffBezanson JeffBezanson deleted the jb/setproplowering branch January 31, 2019 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengj stevengj stevengj approved these changes

@vtjnash vtjnash Awaiting requested review from vtjnash

Assignees
No one assigned
Labels
compiler:lowering Syntax lowering (compiler front end, 2nd stage)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeffBezanson @stevengj