fix at-everywhere using in Distributed stdlib
#30804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
domain:parallelism
Why didn't the tests catch this? |
|
We don't have a test that this feature works as intended. I suppose it's tricky to test --- we need to somehow check that no precompilation was attempted on processors other than 1. |
StefanKarpinski
added
status:triage
JeffBezanson
removed
status:triage
KristofferC
pushed a commit
that referenced
this pull request
Feb 4, 2019
(cherry picked from commit 17c4b02)
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
(cherry picked from commit 17c4b02)
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
(cherry picked from commit 17c4b02)
KristofferC
pushed a commit
that referenced
this pull request
Apr 20, 2019
(cherry picked from commit 17c4b02)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
(cherry picked from commit 17c4b02)
vchuravy
pushed a commit
to JuliaLang/Distributed.jl
that referenced
this pull request
Oct 6, 2023
(cherry picked from commit a670e09)
Keno
pushed a commit
that referenced
this pull request
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distributeddoes a transformation of@everywhere using Xto try to do the importing locally first, to avoid precompilation races. However this has been broken since 0.7 due to a changed AST representation. This should fix it.