Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force specialization of the SubArray boundserror method. #30666

Merged
merged 1 commit into from
Jan 10, 2019

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jan 9, 2019

Improves #29867 by avoiding an invoke.
Will run @nanosoldier when CI is green.

@maleadt maleadt added the domain:arrays [a, r, r, a, y, s] label Jan 9, 2019
@KristofferC
Copy link
Sponsor Member

See the discussion starting at #29867 (comment).

@maleadt
Copy link
Member Author

maleadt commented Jan 9, 2019

@nanosoldier runbenchmarks(ALL, vs = ":master")

@maleadt
Copy link
Member Author

maleadt commented Jan 10, 2019

Nanosoldier not feeling well?
@nanosoldier runbenchmarks(ALL, vs = ":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@KristofferC KristofferC merged commit bb636aa into master Jan 10, 2019
@KristofferC KristofferC deleted the tb/subarray_boundserror_invoke branch January 10, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:arrays [a, r, r, a, y, s]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants