Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor resolve-scopes pass #30656

Merged
merged 1 commit into from
Jan 16, 2019
Merged

refactor resolve-scopes pass #30656

merged 1 commit into from
Jan 16, 2019

Conversation

JeffBezanson
Copy link
Sponsor Member

This is a much-needed rewrite of resolve-scopes. Many reasons have accumulated:

The code for it has grown quite confusing and unmaintainable, making it hard to address these issues. Hopefully this PR makes it much easier to read and modify. It also removes a bunch of code that was only really needed to deprecate the pre-0.7 global scope behavior, but was hard to tease apart.

So far I have a pretty good first cut that builds and passes test-core and test-syntax. It already fixes some obscure corner cases (see test).

@JeffBezanson JeffBezanson added the compiler:lowering Syntax lowering (compiler front end, 2nd stage) label Jan 8, 2019
@ViralBShah
Copy link
Member

And it is a net deletion of code (at least as of now)!

@JeffBezanson JeffBezanson force-pushed the jb/resolvescopes branch 2 times, most recently from 241f9ee to f196d02 Compare January 9, 2019 18:43
@JeffBezanson JeffBezanson changed the title WIP: refactor resolve-scopes pass refactor resolve-scopes pass Jan 9, 2019
@JeffBezanson
Copy link
Sponsor Member Author

Ok, PkgEval identified one problem with underscore handling 🎉 Now this should be ready to go.

@JeffBezanson JeffBezanson merged commit b70ad64 into master Jan 16, 2019
@JeffBezanson JeffBezanson deleted the jb/resolvescopes branch January 16, 2019 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:lowering Syntax lowering (compiler front end, 2nd stage)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants