Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary named let in parse-assignment #30511

Merged
merged 1 commit into from
Dec 26, 2018
Merged

remove unnecessary named let in parse-assignment #30511

merged 1 commit into from
Dec 26, 2018

Conversation

bicycle1885
Copy link
Member

The loop is not used in the function body and let* is much clearer to readers.

@ararslan ararslan added the parser Language parsing and surface syntax label Dec 25, 2018
@JeffBezanson JeffBezanson merged commit 71518a3 into JuliaLang:master Dec 26, 2018
@bicycle1885 bicycle1885 deleted the fix-parse-assignment branch December 27, 2018 10:04
staticfloat pushed a commit that referenced this pull request Dec 30, 2018
@bicycle1885 @staticfloat
remove unnecessary named let in parse-assignment (#30511)
b5c29e7
staticfloat pushed a commit that referenced this pull request Jan 4, 2019
@bicycle1885 @staticfloat
remove unnecessary named let in parse-assignment (#30511)
ea03283
Keno added a commit that referenced this pull request Mar 7, 2020
@Keno
Run FD stress test in separate process
dfd6494 
As noted in #35011, the `stress` test is likely causing ENOMEM
errors in unrelated processes on FreeBSD as it's causing kernel
resource exhaustion. This fixes that by running that test with
a low FD ulimit (100). Should fix #23143. Closes #30511.
@Keno Keno mentioned this pull request Mar 7, 2020
Merged
Keno added a commit that referenced this pull request Mar 8, 2020
@Keno
Run FD stress test in separate process (#35040)
e13d06f 
As noted in #35011, the `stress` test is likely causing ENOMEM
errors in unrelated processes on FreeBSD as it's causing kernel
resource exhaustion. This fixes that by running that test with
a low FD ulimit (100). Should fix #23143. Closes #30511.
ravibitsgoa pushed a commit to ravibitsgoa/julia that referenced this pull request Apr 9, 2020
@Keno @ravibitsgoa
Run FD stress test in separate process (JuliaLang#35040)
b8a5e5e 
As noted in JuliaLang#35011, the `stress` test is likely causing ENOMEM
errors in unrelated processes on FreeBSD as it's causing kernel
resource exhaustion. This fixes that by running that test with
a low FD ulimit (100). Should fix JuliaLang#23143. Closes JuliaLang#30511.
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
@Keno @KristofferC
Run FD stress test in separate process (#35040)
d042adc 
As noted in #35011, the `stress` test is likely causing ENOMEM
errors in unrelated processes on FreeBSD as it's causing kernel
resource exhaustion. This fixes that by running that test with
a low FD ulimit (100). Should fix #23143. Closes #30511.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan approved these changes

@JeffBezanson JeffBezanson Awaiting requested review from JeffBezanson

Assignees
No one assigned
Labels
parser Language parsing and surface syntax
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bicycle1885 @ararslan @JeffBezanson