Fix issue ref typo in comments of doc/make.jl (#30489)
#30490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the doc/make.jl, there is a code block for making links for stdlib. It mentioned JuliaDocs/Documenter.jl#522 in the comment but JuliaDocs/Documenter.jl#522 seems not relevant to this and it should be JuliaDocs/Documenter.jl#552. Fix JuliaLang#30489.
fredrikekre
approved these changes
Dec 22, 2018
|
Thanks, and welcome as a contributor to Julia! |
staticfloat
pushed a commit
that referenced
this pull request
Dec 30, 2018
In the doc/make.jl, there is a code block for making links for stdlib. It mentioned JuliaDocs/Documenter.jl#522 in the comment but JuliaDocs/Documenter.jl#522 seems not relevant to this and it should be JuliaDocs/Documenter.jl#552. Fix #30489.
staticfloat
pushed a commit
that referenced
this pull request
Jan 4, 2019
In the doc/make.jl, there is a code block for making links for stdlib. It mentioned JuliaDocs/Documenter.jl#522 in the comment but JuliaDocs/Documenter.jl#522 seems not relevant to this and it should be JuliaDocs/Documenter.jl#552. Fix #30489.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the doc/make.jl, there is a code block for making links for
stdlib. It mentioned JuliaDocs/Documenter.jl#522 in the comment
but JuliaDocs/Documenter.jl#522 seems not relevant to this and
it should be JuliaDocs/Documenter.jl#552.
Fix #30489.