Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reinterpret for 0-dimensional arrays #30376

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Fix reinterpret for 0-dimensional arrays #30376

merged 1 commit into from
Dec 14, 2018

Conversation

meggart
Copy link
Contributor

@meggart meggart commented Dec 13, 2018

On current master reinterpret is broken for 0-dimensional arrays, e.g. reinterpret(Int32,zeros(UInt32)) throws an error. This should be fixed by this PR.

mbauman
mbauman approved these changes Dec 13, 2018
View reviewed changes
Copy link
Sponsor Member

@mbauman mbauman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fredrikekre fredrikekre added domain:arrays [a, r, r, a, y, s] kind:bugfix This change fixes an existing bug backport pending 1.0 labels Dec 13, 2018
@KristofferC KristofferC mentioned this pull request Dec 13, 2018
Merged
52 tasks
@fredrikekre fredrikekre merged commit c379900 into JuliaLang:master Dec 14, 2018
KristofferC pushed a commit that referenced this pull request Dec 20, 2018
@meggart @KristofferC
fix reinterpret for 0-dimensional arrays (#30376)
0d9fee8 
(cherry picked from commit c379900)
KristofferC pushed a commit that referenced this pull request Dec 30, 2018
@meggart @KristofferC
fix reinterpret for 0-dimensional arrays (#30376)
33f48cd 
(cherry picked from commit c379900)
@KristofferC KristofferC mentioned this pull request Dec 30, 2018
Closed
53 tasks
KristofferC pushed a commit that referenced this pull request Jan 5, 2019
@meggart @KristofferC
fix reinterpret for 0-dimensional arrays (#30376)
80ed982 
(cherry picked from commit c379900)
KristofferC pushed a commit that referenced this pull request Jan 5, 2019
@meggart @KristofferC
fix reinterpret for 0-dimensional arrays (#30376)
c4a4eec 
(cherry picked from commit c379900)
@StefanKarpinski StefanKarpinski added status:triage This should be discussed on a triage call backport 1.0 and removed status:triage This should be discussed on a triage call labels Jan 31, 2019
@JeffBezanson JeffBezanson removed status:triage This should be discussed on a triage call triage backport pending 1.0 labels Jan 31, 2019
KristofferC pushed a commit that referenced this pull request Feb 4, 2019
@meggart @KristofferC
fix reinterpret for 0-dimensional arrays (#30376)
3d712b3 
(cherry picked from commit c379900)
@KristofferC KristofferC mentioned this pull request Feb 4, 2019
Merged
39 tasks
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@meggart @KristofferC
fix reinterpret for 0-dimensional arrays (#30376)
6e62b10 
(cherry picked from commit c379900)
KristofferC pushed a commit that referenced this pull request Apr 20, 2019
@meggart @KristofferC
fix reinterpret for 0-dimensional arrays (#30376)
7e8d9b2 
(cherry picked from commit c379900)
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
@meggart @KristofferC
fix reinterpret for 0-dimensional arrays (#30376)
776a251 
(cherry picked from commit c379900)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbauman mbauman mbauman approved these changes

Assignees
No one assigned
Labels
domain:arrays [a, r, r, a, y, s] kind:bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@meggart @mbauman @StefanKarpinski @JeffBezanson @KristofferC @fredrikekre