Repair rand{T<:Integer}(r::Range1{T}) for signed types. Closes #3004. #3008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKarpinski
added a commit
that referenced
this pull request
May 3, 2013
Repair rand{T<:Integer}(r::Range1{T}) for signed types. Closes #3004.
|
I merged this because the use of |
ViralBShah
added
the
domain:randomness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request restores the rand(r::Range1) function to the state before 6e6b057#base/random.jl to solve the regression reported in #3004. There are other edge case issues in the function but I'll come back to those at a later time.
I'm not sure about the value of the testcase. Generating 100000 random numbers to test this specific problem is maybe not motivated. What this patch really needs is careful code review.