Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate_precompile script: try to improve reliability #30040

Merged
merged 1 commit into from
May 8, 2019

Conversation

vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented Nov 14, 2018

TTY objects are inherently unreliable input channels (documented, per posix design),
so try to slow down the rate of input and speed up the rate of output
by watching the output stream more closely, and detecting intermediate errors.

And also just general cleanup some of our IO handling.

base/iostream.jl Outdated Show resolved Hide resolved
@vtjnash vtjnash force-pushed the jn/fixup-pty-and-precompile branch 4 times, most recently from 28f8e1f to ceb41e3 Compare March 29, 2019 19:47
@ghost
Copy link

ghost commented Apr 4, 2019

I've discovered that I cannot build on master with ENABLE_TIMINGS enabled. When I do, it hangs forever (i haven't let it run more than an hour, to be fair) during Generating precompile statements....

I am building from b471640, but i have also tried building from 4c2e570 and I saw the same result.

I am on macOS, and this is occurring in a freshly cloned julia repo, both with USE_BINARYBUILDER=0 and without.

EDIT: .... i have no idea why i posted this comment here. Haha I'm sorry. It looks like i might've posted in the wrong thread? Please ignore it.

TTY objects are inherently unreliable input channels (documented, per posix design),
so try to slow down the rate of input and speed up the rate of output
by watching the output stream more closely, and detecting intermediate errors.
@vtjnash vtjnash force-pushed the jn/fixup-pty-and-precompile branch from ca1dedf to 954510f Compare April 19, 2019 21:54
@vtjnash vtjnash merged commit c9777b0 into master May 8, 2019
@vtjnash vtjnash deleted the jn/fixup-pty-and-precompile branch May 8, 2019 14:34
@Keno
Copy link
Member

Keno commented Jun 3, 2020

I've looked into this a bit. The part where it drops data is if the TTY is in canonical mode, where it will stop accepting non-special bytes past a line length of 4095 (https://github.com/torvalds/linux/blob/master/drivers/tty/n_tty.c#L1679-L1683).

@NHDaly NHDaly assigned NHDaly and unassigned NHDaly Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants