inference: remove ability to infer f(svec(a, b, c)...)
#29935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems unlikely that this code pattern is used anywhere, and it is the last instance of this inference hack we have remaining (after the PartialTuple work). If some package does end up needing it, we can reimplement it (via adding PartialSimpleVector), but I strongly suspect this is effectively dead-code, and thus not worthwhile to maintain.
|
I assume we're still ok if the whole svec is |
|
Right, this only handled the exact syntax form above |
|
Actually I've been wondering if we should change the lowering of splatting to use |
|
Well, as I said, it's effectively dead code right now, and we can implement a better copy of it when and if we actually need it. |
tkf
pushed a commit
to tkf/julia
that referenced
this pull request
Nov 21, 2018
) It seems unlikely that this code pattern is used anywhere, and it is the last instance of this inference hack we have remaining (after the PartialTuple work). If some package does end up needing it, we can reimplement it (via adding PartialSimpleVector), but I strongly suspect this is effectively dead-code, and thus not worthwhile to maintain.
vtjnash
added a commit
that referenced
this pull request
Nov 28, 2018
Uses of this function previously assumed that all Slots were SSA. Fortunately, we now just have one user (post #29935) and it has very simple requirements so we can check conservatively for this case without loss of (much) accuracy.
vtjnash
added a commit
that referenced
this pull request
Nov 29, 2018
Uses of this function previously assumed that all Slots were SSA. Fortunately, we now just have one user (post #29935) and it has very simple requirements so we can check conservatively for this case without loss of (much) accuracy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems unlikely that this code pattern is used anywhere (since the code would need to literally syntactically call
svecand immediately splat the result into another call--as shown above), and it is the last instance of this inference hack we have remaining (after the PartialTuple work). If some package does end up needing it, we can easily reimplement it much better (via adding PartialSimpleVector), but I strongly suspect this is effectively dead-code, and thus not worthwhile to maintain.