adding _small_enough for diagonal so that fill! works #29780
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_small_enough
wasn't defined forDiagonal
sofill!(::Diagonal, x)
returns a method error even if the diagonal matrix is small enough.2 small questions: should the fill and fillstored tests be in test/special.jl (instead of bidiag.jl) since that is where they are defined? And should fillstored be exported by LinearAlgebra?